let PointerValue::invalidate() be noexcept#47354
Closed
yfeldblum wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65271399 |
Job Summary for GradleTest All :: build_android
|
Summary: Pull Request resolved: #47331 Reviewed By: Gownta Differential Revision: D65271354
Summary: `PointerValue::invalidate()` is called from `Pointer` destructor, which is implicitly `noexcept`, and from `Pointer` move-assignment operator, which is now `noexcept`. Reviewed By: neildhar Differential Revision: D65271399
facebook-github-bot
force-pushed
the
export-D65271399
branch
from
e87bf1f to
a8160ec
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65271399 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Summary: `PointerValue::invalidate()` is called from `Pointer` destructor, which is implicitly `noexcept`, and from `Pointer` move-assignment operator, which is now `noexcept`. Reviewed By: neildhar Differential Revision: D65271399
Job Summary for GradleTest All :: build_android
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65271399 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65271399 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 7, 2024
Summary: X-link: facebook/react-native#47354 `PointerValue::invalidate()` is called from `Pointer` destructor, which is implicitly `noexcept`, and from `Pointer` move-assignment operator, which is now `noexcept`. Reviewed By: neildhar Differential Revision: D65271399 fbshipit-source-id: 26fd9707e4389da78537d0d607adaef0c68690ca
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 7, 2024
Summary: X-link: facebook/react-native#47354 `PointerValue::invalidate()` is called from `Pointer` destructor, which is implicitly `noexcept`, and from `Pointer` move-assignment operator, which is now `noexcept`. Reviewed By: neildhar Differential Revision: D65271399 fbshipit-source-id: 26fd9707e4389da78537d0d607adaef0c68690ca
Contributor
|
This pull request has been merged in f01b472. |
Collaborator
|
This pull request was successfully merged by @yfeldblum in f01b472 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PointerValue::invalidate()is called fromPointerdestructor, which is implicitlynoexcept, and fromPointermove-assignment operator, which is nownoexcept.Differential Revision: D65271399